On Thu, 17 Dec 2020 12:11:33 GMT, Jie Fu <ji...@openjdk.org> wrote: > Hi all, > > java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'. > The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms. > The current implementation only supports maximum 3800M on 32-bit systems [1]. > > I've tried to reduce the -Xmx size, but it still fails even with -Xmx2G. > So this test seems to be brittle on 32-bit platforms since 2G is already > larger than 3800M/2=1900M. > The fix just skips the test for 32-bit systems. > > Thanks. > Best regards, > Jie > > [1] > https://github.com/openjdk/jdk/blob/master/src/hotspot/os/posix/os_posix.cpp#L567
Disabling all of the tests on 32 bit is not a good idea. Instead the HexFormatTest.testOOME test should be skipped or the OOME should be ignored. Checking Runtime.getRuntime().maxMemory() should provide enough info to skip it. ------------- Changes requested by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1817
