> Hi all,
> 
> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
> The current implementation only supports maximum 3800M on 32-bit systems [1].
> 
> I've tried to reduce the -Xmx size, but it still fails even with -Xmx2G.
> So this test seems to be brittle on 32-bit platforms since 2G is already 
> larger than 3800M/2=1900M.
> The fix just skips the test for 32-bit systems.
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] 
> https://github.com/openjdk/jdk/blob/master/src/hotspot/os/posix/os_posix.cpp#L567

Jie Fu has updated the pull request incrementally with one additional commit 
since the last revision:

  Skip OOME

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1817/files
  - new: https://git.openjdk.java.net/jdk/pull/1817/files/38d4d01a..83cbdaaf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1817&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1817&range=01-02

  Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1817.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1817/head:pull/1817

PR: https://git.openjdk.java.net/jdk/pull/1817

Reply via email to