On Tue, 12 Jan 2021 23:56:12 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Please review a patch to add an explicit control over whether a newline >> should be added after the XML header. This is done by adding a DOM >> LSSerializer property "jdk-is-standalone" and System property >> "jdk.xml.isStandalone". >> >> This change addresses an incompatibility introduced during 7u4 as an update >> to Xalan 2.7.1. > > src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/DOMConstants.java > line 131: > >> 129: >> 130: // Corresponding System property >> 131: public static final String SP_IS_STANDALONE = >> "jdk.xml.isStandalone"; > > Should this system property key be described somewhere in the javadoc, as an > Oracle implSpec? Otherwise, how the user would know this switch? So far as with the current practice, we would document JDK specific properties in the Release Notes (refer to the Release Note sub-task for this particular property). We also created tutorials for the ones that are within a major topic (e.g. security). Plus, even if we'd want to add an implSpec, we wouldn't be able to since the DOM's license is quite restrictive. ------------- PR: https://git.openjdk.java.net/jdk/pull/2041
