On Wed, 27 Jan 2021 15:34:26 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update: add javadoc for impl specific features and properties in
>> module-info; update the patch accordingly.
>
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/LSSerializerImpl.java
> line 639:
>
>> 637: if (state) {
>> 638:
>> fDOMConfigProperties.setProperty(DOMConstants.S_JDK_PROPERTIES_NS
>> 639: + DOMConstants.S_IS_STANDALONE, "yes");
>
> Multiple concatenations of the same strings, seems awkward at best and
> perhaps a maintenance burden.
> Would it make sense to declare them as static strings?
> Though in this case, it could be a single call to setProperty with the value
> being `(state ? "yes" : "no")`
Will do. I'll see if we should do the same with the existing ones.
> src/java.xml/share/classes/module-info.java line 58:
>
>> 56: * The prefix for System Properties:
>> 57: * <pre>
>> 58: * {@systemProperty jdk.xml.}
>
> The use of {@systemProperty...} seems inappropriate, it should be used to
> refer to specific properties. (IMHO)
will change to @code.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2041
