On Fri, 29 Jan 2021 00:07:59 GMT, Joe Wang <[email protected]> wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
>> This change addresses an incompatibility introduced during 7u4 as an update
>> to Xalan 2.7.1.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated the patch based on review comments. Refer to the previous reviews.
I have just two cosmetic comments. Otherwise LGTM!
src/java.xml/share/classes/module-info.java line 78:
> 76: * <h3>System Properties</h3>
> 77: * A property may have a corresponding System Property that has the same
> name
> 78: * except the prefix as shown above. A System Property should be set
> prior to
should that be "except for the prefix"?
src/java.xml/share/classes/module-info.java line 188:
> 186: * </tbody>
> 187: * </table>
> 188: *
One question is whether the code samples in the table above should be escaped
with {@code }. e.g.:
<td>
{@code first line of code;}<br>
{@code second line of code;}<br>
</td>
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2041
