On Tue, 16 Feb 2021 11:48:05 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Evan Whelan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8252883: Doc cleanup, code formatting and throwing exceptions instead of >> catching > > test/jdk/java/util/logging/FileHandlerAccessTest.java line 96: > >> 94: System.out.println(name + "\t|" + line); >> 95: } >> 96: childProcess.waitFor(); > > Should you be checking the status returned by `waitFor` and fail the test if > it's not `0`? I'll modify the code to add this behaviour. Thanks for the suggestion :) ------------- PR: https://git.openjdk.java.net/jdk/pull/2572
