On Wed, 17 Feb 2021 12:24:46 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Remove ClassPathException copyright statement
>
> test/jdk/java/util/logging/FileHandlerAccessTest.java line 45:
>
>> 43: if (!(args.length == 2 || args.length == 1)) {
>> 44: System.out.println("Usage error: expects java
>> FileHandlerAccessTest [process/thread] <count>");
>> 45: return;
>
> Ah - sorry - since this is a test, instead of return you should probably
> throw an exception - e.g.:
> throw new IllegalArgumentException("Usage error: expects java
> FileHandlerAccessTest [process/thread] <count>");
Done! Thanks Daniel
> test/jdk/java/util/logging/FileHandlerAccessTest.java line 47:
>
>> 45: return;
>> 46: }
>> 47: else if (args.length == 2) {
>
> nit: `} else if (...) {`
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/2572
