On Mon, 3 May 2021 15:58:56 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8266179: [macos] jpackage should specify architecture for produced pkg >> files [v2] > > test/jdk/tools/jpackage/macosx/HostArchPkgTest.java line 55: > >> 53: >> 54: private static void verifyHostArch(JPackageCommand cmd) throws >> Exception { >> 55: Path distributionFile = cmd.unpackedPackageDirectory() > > I think `cmd.pathToUnpackedPackageFile("/")` would be the equivalent to > `cmd.unpackedPackageDirectory()`. If it is, there would be no need for > changes to JPackageCommand. Fixed. > test/jdk/tools/jpackage/macosx/HostArchPkgTest.java line 84: > >> 82: } >> 83: >> 84: public static void main(String[] args) throws Exception { > > Please don't use direct TKit.run() call. Use > jdk.jpackage.test.Annotations.Test annotation for test method. You can use > SimplePackageTest jtreg test as an example I will fix it. Do we have a bug or I can file one to fix other tests? We have several tests such as SigningPackageTest which uses TKit.run() call and I just copy paste it. ------------- PR: https://git.openjdk.java.net/jdk/pull/3807