On Thu, 13 May 2021 20:38:20 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> HI all,
>>
>> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>>
>> The fix adds a no-arg constructor which TestNG requires.
>>
>> The change allows the test to run with the current jtreg as well as the
>> upcoming jtreg
>>
>>
>> Best
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust imports and spacing
Marked as reviewed by alanb (Reviewer).
test/jdk/tools/jmod/hashes/HashesTest.java line 389:
> 387: ModuleReference mref =
> finder.find(name).orElseThrow(RuntimeException::new);
> 388: try {
> 389: try (ModuleReader reader = mref.open(); InputStream in =
> reader.open("module-info.class").get()) {
Thats for doing the right thing and using BeforeMethod. The changes looks good.
There is some random re-formatting in hashes and deleteDirectory, I don't know
if this was intended or not. I think we should at least resolve L389 before
integrating.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4009
