On Fri, 14 May 2021 08:02:29 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust imports and spacing > > test/jdk/tools/jmod/hashes/HashesTest.java line 389: > >> 387: ModuleReference mref = >> finder.find(name).orElseThrow(RuntimeException::new); >> 388: try { >> 389: try (ModuleReader reader = mref.open(); InputStream in = >> reader.open("module-info.class").get()) { > > Thats for doing the right thing and using BeforeMethod. The changes looks > good. > There is some random re-formatting in hashes and deleteDirectory, I don't > know if this was intended or not. I think we should at least resolve L389 > before integrating. Thank you Alan. The re-formatting was done automagically by Intellij. I just pushed an update to address your suggestions. ------------- PR: https://git.openjdk.java.net/jdk/pull/4009