On Thu, 26 Aug 2021 09:26:24 GMT, Wu Yan <wu...@openjdk.org> wrote: >> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4871: >> >>> 4869: // exit from large loop when less than 64 bytes left to read or >>> we're about >>> 4870: // to prefetch memory behind array border >>> 4871: int largeLoopExitCondition = MAX(64, >>> SoftwarePrefetchHintDistance)/(isLL ? 1 : 2); >> >> This breaks the Windows AArch64 build: >> >> >> Creating support/modules_libs/java.base/server/jvm.dll from 1051 file(s) >> d:\a\jdk\jdk\jdk\src\hotspot\cpu\aarch64\stubGenerator_aarch64.cpp(4871): >> error C3861: 'MAX': identifier not found >> make[3]: *** [lib/CompileJvm.gmk:143: >> /cygdrive/d/a/jdk/jdk/jdk/build/windows-aarch64/hotspot/variant-server/libjvm >> >> >> https://github.com/Wanghuang-Huawei/jdk/runs/3260986937 >> >> Should probably be left as `MAX2`. > > Thanks, I'll fix it.
It's fine. I don't think it'll affect any real programs, so it's rather pointless. I don't know if that's any reason not to approve it. ------------- PR: https://git.openjdk.java.net/jdk/pull/4722
