On Wed, 4 Aug 2021 03:27:49 GMT, Nick Gasson <ngas...@openjdk.org> wrote:
>> Wang Huang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - fix bugs >> - Merge branch 'master' of https://gitee.com/ustc-wh/jdk into JDK-8268231 >> - fix style and add unalign test case >> - refact codes >> - draft of refactor >> - 8268231: Aarch64: Use ldp in intrinsics for String.compareTo > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4892: > >> 4890: __ cmp(tmp1, tmp2); >> 4891: __ ccmp(tmp1h, tmp2h, 0, Assembler::EQ); >> 4892: __ br(__ NE, DIFF); > > The line above uses `Assembler::EQ` for the condition code but this line uses > `__ NE`. Better to be consistent and use `Assembler::` everywhere. Thanks, I'll fix it. ------------- PR: https://git.openjdk.java.net/jdk/pull/4722
