On Fri, 5 Nov 2021 20:34:06 GMT, Joe Wang <jo...@openjdk.org> wrote:

>> Add setProperty/getProperty methods to the XPath API so that properties can 
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Exception: changed from XPathFactoryConfigurationException to 
> IllegalArgumentException

src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 425:

> 423:         }
> 424:         throw new UnsupportedOperationException("not implemented");
> 425:     }

Changing it to throw IAE looks much better.  You can drop "throws 
IllegalArgumentException" from the method signature as it's a runtime exception.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6215

Reply via email to