On Mon, 8 Nov 2021 11:38:52 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Removing IAE from the method signature; Update impl and test.
>
> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 375:
> 
>> 373:     /**
>> 374:      * Sets a property for this {@code XPathFactory} and {@code XPath}
>> 375:      * created by this factory.
> 
> Are properties inherited by the XPath object at create time? The javadoc for 
> newXPath suggests so and I'm wondering if the javadoc for setProperty needs 
> to consistent with that. Maybe the intention is really that this method sets 
> a XPathFactory property and it is used when configuring the XPath object 
> returned by the newXPath method.

Yes. Made a clarification to the javadoc, and while we are here, to setFeature 
method as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6215

Reply via email to