On Sat, 8 Jan 2022 16:09:59 GMT, Lance Andersen <lan...@openjdk.org> wrote:

>> Masanori Yano has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> Thank you for your work here.   Have you also run your test using Apache 
> Commons?
> 
> I have run this test over 2000 times via Mach5 on various hardware with some 
> runs taking over 12 minutes for the test to complete.  So unless you can 
> refactor the test to be more efficient, we need to make the test a manual 
> test as this is more of a corner case.
> 
> Please see the additional comments below

@LanceAndersen Thank you for your detailed comments. I converted the test to 
use TestNG as you pointed out.
Could you please review it again?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6927

Reply via email to