On Tue, 25 Jan 2022 14:36:26 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix accident argument ordering after edit > > src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java > line 107: > >> 105: >> 106: public Object invokeDefault(Object proxy, Method method, Object[] >> args, Class<?> caller) >> 107: throws Throwable; > > Minor nit: add a comment to the method so that it's consistent with the other > JLRA methods. What about this: /** Invokes the given default method if the method's declaring interface is * accessible to the given caller. Otherwise, IllegalAccessException will * be thrown. If the caller is null, no access check is performed. */ public Object invokeDefault(Object proxy, Method method, Object[] args, Class<?> caller) throws Throwable; ------------- PR: https://git.openjdk.java.net/jdk/pull/7185