On Thu, 3 Feb 2022 06:35:47 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> kabutz has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Updated comment to include information about performance > > src/java.base/share/classes/java/math/BigInteger.java line 1603: > >> 1601: * parallel multiplication algorithm will use more CPU resources >> 1602: * to compute the result faster, with no increase in memory >> 1603: * consumption. > > The implNote should cover a space of possible parallel multiply > implementations so it doesn't have to be updated as often as the > implementation is tuned or adjusted. So I'd prefer to have a statement like > "may use more memory" even if the current implementation doesn't actually use > more memory. If there are any "contraindications" on when to use the method, > they could be listed here too. @kabutz I approved, but can you address Joe's comment, then i will update the CSR. ------------- PR: https://git.openjdk.java.net/jdk/pull/6409
