On Thu, 5 May 2022 15:21:23 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> The isMusl method had to be handled in > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . > Additionally, the vm.musl predicate seem not to be available in the langtools > tests. Changes requested by dcubed (Reviewer). test/langtools/jdk/jshell/ExternalEditorTest.java line 29: > 27: * @bug 8143955 8080843 8163816 8143006 8169828 8171130 8162989 8210808 > 28: * @comment musl/Alpine has problems executing some shell scripts, see > 8285987 > 29: * @requires !vm.musl So this change backs out an "@requires" that was added by: JDK-8285987 executing shell scripts without #! fails on Alpine linux https://bugs.openjdk.java.net/browse/JDK-8285987 Presumably this "@requires" was added for some reason so what's going to happen if this test is run on Alpine Linux? Also, the fix in JDK-8285987 updated the copyright year. Do you plan on restoring it to the original "2017" value? ------------- PR: https://git.openjdk.java.net/jdk/pull/8556
