On Wed, 27 Apr 2022 15:50:20 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains six >> additional commits since the last revision: >> >> - Merge branch 'master' into typos-in-corelibs >> - Fixes comments in review: >> >> * Reverting changes in jdwp.spec >> * Fix "is occurs" >> * Stop providing "Syncchronication" providers :-) >> * Fix fEncoder reduplication. >> * Revert changes in XMLEventReaderImpl.java >> - Pass #2 core >> - Pass #1 core >> - Pass #2 misc >> - Pass #1 misc > > Since you've changed some code; you need to run tests for tiers 1-3. > > (Note that even for trivial changes, hundreds of OpenJDK developers are > notified and distracted; be considerate of other developers). I believe I have addressed all feedback in the review, with the possible exception of 3rd party source. @RogerRiggs Are there more 3rd party files I have inadvertently modified, apart from `XMLEventReaderImpl.java`? ------------- PR: https://git.openjdk.java.net/jdk/pull/8364