On Mon, 27 Jun 2022 17:57:53 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Alex Kasko has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use shortcut to test arguments, add argument with spaces > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixAppImageFragmentBuilder.java > line 533: > >> 531: xml.writeAttribute("Command", "Open"); >> 532: if (fa.passAllArguments) { >> 533: xml.writeAttribute("Argument", "\"%1\" %*"); > > Wondering if simple `"%*"` would be sufficient to preserve arguments with > spaces. I've added argument with spaces to the test, they seem to be passed correctly (with existing unquoted `%*`) with both command line invocation and with a shortcut. ------------- PR: https://git.openjdk.org/jdk/pull/9224