On Wed, 3 Aug 2022 12:54:38 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - 6478546: Miscellaneous cleanup >> - Merge >> - Merge >> - 6478546: Use dynamically sized temporary direct buffers >> - Merge >> - Merge >> - 6478546: Add break in write loop on ExceptionOccurred >> - Merge >> - 6478546: Clean up io_util.c >> - Merge >> - ... and 2 more: https://git.openjdk.org/jdk/compare/fd00ab21...9a138636 > > src/java.base/share/classes/java/io/RandomAccessFile.java line 112: > >> 110: } >> 111: >> 112: int multiple = (len + MIN_BUFFER_SIZE - 1)/MIN_BUFFER_SIZE; > > isn't that equivalent `(len / MIN_BUFFER_SIZE) + 1`, given that len cannot be > 0 or a multiple of MIN_BUFFER_SIZE? Yes, I think you are correct. Good catch! ------------- PR: https://git.openjdk.org/jdk/pull/8235
