On Tue, 26 Jul 2022 09:25:48 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated ClassDesc::ofInternal javadoc with JVMS link and fixed indentation > > test/jdk/java/lang/constant/ClassDescTest.java line 268: > >> 266: } >> 267: >> 268: List<String> badInternalNames = List.of("I;", "[]", > > is `[]` a good test for arrays? Wouldn't something more realistic like > `[Ljava/lang/String` be better? I note that `[]` is also used in another > test. Problem with testing `[]` is that if the checking logic has a bug, or a > regression is introduced so that it only detects `]` instead of `[` the test > would not detect that (but I guess that's a remote possibility). Thanks for pointing it out, I'll add a valid array descriptor into the list of badInternalNames. ------------- PR: https://git.openjdk.org/jdk/pull/9201