On Tue, 30 Aug 2022 08:58:30 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation >> >> use private for methods which changed signature > > src/java.base/share/classes/java/text/PatternEntry.java line 55: > >> 53: * Gets the current extension, quoted >> 54: */ >> 55: public void appendQuotedExtension(StringBuilder toAddTo) { > > Hello Andrey, this and the other `public` method that's changed in this > (package private) class don't seem to be used anywhere else other than this > class itself. So maybe you could change them to `private` as part of this > change? Changed a few of methods to `private` ------------- PR: https://git.openjdk.org/jdk/pull/10007