On Mon, 12 Sep 2022 12:06:07 GMT, Jaikiran Pai <[email protected]> wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add run for the SP w/o value, formatting/wording updates
>
> test/jdk/com/sun/jndi/ldap/objects/RemoteLocationAttributeTest.java line 64:
>
>> 62: SocketAddress sockAddr = new InetSocketAddress(
>> 63: InetAddress.getLoopbackAddress(), 0);
>> 64: serverSocket.bind(sockAddr);
>
> Perhaps we should `close()` this `serverSocket` in a finally block to cleanly
> shutdown?
Good idea, thanks. Will add it to try-with-resources statement, like:
`try (serverSocket) {
`
-------------
PR: https://git.openjdk.org/jdk/pull/10228
