On Thu, 15 Sep 2022 06:51:34 GMT, Rahul Prabhu <[email protected]> wrote:
>> Created two files for testing XPath Axes: XPathAncestors.java tests the
>> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the
>> preceding and preceding-sibling axes.
>
> Rahul Prabhu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289508: fixed whitespace
Looks good overall.
Note that if the editor you use is prone to add whitespaces, running the
normalizer before commit would do the trick.
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathAncestorsTest.java line 121:
> 119:
> 120: /*
> 121: * DataProvider: provides XPath expressions that return null
... expressions that return empty NodeSet.
Note that the test called to evaluate to a Node though the expressions
themselves return an empty NodeSet.
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathAncestorsTest.java line 124:
> 122: */
> 123: @DataProvider(name = "noResults")
> 124: public Object[][] getNoResults() {
s/noResults/emptyNodeSet. Refer to the above, it's therefore not that it
returns "no result" but the processor treats requesting Node on an empty
NodeSet as null.
-------------
PR: https://git.openjdk.org/jdk/pull/10211
