On Thu, 18 Aug 2022 21:42:04 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into JDK-8287597
>> - JDK-8287597: List all preview features on the javadoc PREVIEW page
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SummaryListWriter.java
> line 164:
>
>> 162: protected void addIndexLink(HtmlId id, String headingKey, Content
>> content) {
>> 163: var li = HtmlTree.LI(links.createLink(id,
>> 164:
>> contents.getContent(headingKey))).setId(HtmlId.of("contents-" + id.name()));
>
> Suggest adding a comment that `"contents-" + id` appears in the JavaScript
> code as well. You presumably can't change one without the other (and can't
> use a common function across the language barrier.)
Excellent point.
-------------
PR: https://git.openjdk.org/jdk/pull/9336
