On Sun, 25 Sep 2022 16:51:27 GMT, SWinxy <d...@openjdk.org> wrote:

> Oh no what happened

Oops!  Thanks for pointing out the goof.  It seems to be fixed now.

It has now been a month since I opened the pull request, and I have responded 
to each substantive comment promptly.  It would be great to merge this pull 
request to avoid the need for more merges.

> src/java.xml/share/classes/com/sun/org/apache/xpath/internal/NodeSetDTM.java 
> line 1053:
> 
>> 1051:    * fetch will take place at index 1.
>> 1052:    *
>> 1053:    * @return The current position index.
> 
> Note that there is an inconsistent change here, albeit insignificant. In 
> `NodeSet`, the capital 'The' is removed after the `@return`, while the 
> lowercase 'the' is removed here.

Thanks for pointing out the inconsistency.  I have fixed it.  (I noticed many 
violations of the official Javadoc style, but this is not the right pull 
request to fix them.)

-------------

PR: https://git.openjdk.org/jdk/pull/10029

Reply via email to