On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao <d...@openjdk.org> wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Merge branch 'master' into improve-directory-not-existing-error-message > - new approach: print warning in StaticProperty.java > - Merge branch 'master' into improve-directory-not-existing-error-message > - add the change for nio and update the code according to the comments > - new approach > - change based on the review > - updating according to the comments > - Merge branch 'master' of https://github.com/openjdk/jdk into > improve-directory-not-existing-error-message > - update error message > - error message for non-existing directory > - ... and 1 more: https://git.openjdk.org/jdk/compare/8487c56f...2da71bdc The changes in the latest patch don't make sense, maybe there is a merge error? From what I can see, I don't think you should be changing initPhase1 or changing StaticProperty.<clint> to print the warning. A possible starting point for this PR would be to focus on the case that java.io.tmpdir is configured on the command line. If it is, then it would be fair game to eagerly check that it is a directory. One candidate place to emit the warning is initPhase3 where you'll see several other warnings. The other case is the user hasn't configured java.io.tmpdir, in which case it will default to /var/tmp (or whatever) is not a directory. Do you really want the JDK to be checking this every time? What happened to the exploration into extending the security property jdk.includeInExceptions? ------------- PR: https://git.openjdk.org/jdk/pull/9989
