On Tue, 18 Oct 2022 17:26:52 GMT, Brent Christian <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/Basic.java line 93:
>
>> 91: + fail + " failure(s), first",
>> first);
>> 92: else
>> 93: System.out.printf("all " + pass + " tests passed");
>
> This line is missing a newline; add a \n, or use println().
I would suggest rewriting as System.out.printf("all %s tests passed%n", pass);
You could make a similar change to line 90 using String.format as done in the
line 98 which was deleted
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 51:
>
>> 49: private static final String LOCALE_PROV =
>> "-Djava.locale.providers=CLDR";
>> 50: // Test class
>> 51: private static final String SOURCE_CLASS = "Basic";
>
> This is the name of a compiled class to be run, not a source file, so
> perhaps, "TEST_CLASS"?
agree
-------------
PR: https://git.openjdk.org/jdk/pull/10715
