On Tue, 18 Oct 2022 19:20:58 GMT, Brent Christian <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove testing change
>> - Fix formatter in Basic
>
> test/jdk/java/util/Formatter/Basic.java line 90:
>
>> 88:
>> 89: if (fail != 0) {
>> 90: throw new RuntimeException(String.format("%d tests: %d
>> failure(s)" +
>
> You might consider including `", first"` with the rest of the message string,
> instead of concatenating it. That line might end up slightly long, but it may
> be worth it.
>
> Also, use `%s` for`first`, as it's a `Throwable` ;)
> (You could also perhaps change `first` -> `first.toString()` in the final
> argument to format, to clarify.)
Good point, will reassign it to one line.
"Also, use %s forfirst, as it's a Throwable",
I believe I am assigning %d to pass+fail and fail. I pass first as a Throwable
to the runtime exception constructor.
-------------
PR: https://git.openjdk.org/jdk/pull/10715
