On Mon, 14 Nov 2022 13:08:56 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert to using simpler solution similar to the original 8274980 > > make/hotspot/lib/CompileJvm.gmk line 67: > >> 65: # Hotspot cannot handle an empty build number >> 66: VERSION_BUILD := 0 >> 67: endif > > I think the proposed "solution" is *much* worse than this. Reverted to use the original, less intrusive solution from [8274980](https://github.com/openjdk/jdk/pull/11081/commits/83ed3deb29d7344bbc95a3831f2388d077bc59e9) that initially could not work with the older Visual C++ compiler (With a minor improvement to handle #define 0) ------------- PR: https://git.openjdk.org/jdk/pull/11081