On Tue, 8 Nov 2022 23:35:47 GMT, David Holmes <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Forgot a null check.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 540:
>
>> 538:
>> 539: jthread *
>> 540: JvmtiEnvBase::new_jthreadArray(int length, Handle *handles) {
>
> Shouldn't this method need to cast the return value to `jthread*`? And
> potentially shouldn't all the jobject's now be jthread's?
jthread and jthreadGroup are typedefs to jobject in JVMTI spec.
https://docs.oracle.com/en/java/javase/11/docs/specs/jvmti.html#jthread
But I updated the code to have the more specific types.
-------------
PR: https://git.openjdk.org/jdk/pull/11033
