On Fri, 18 Nov 2022 18:38:53 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> JEP 429 implementation. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Add ensureMaterializedForStackWalk kludge for AArch64 src/hotspot/cpu/aarch64/aarch64.ad line 3637: > 3635: __ nop(); > 3636: __ block_comment("call JVM_EnsureMaterializedForStackWalk > (elided)"); > 3637: } else { This should probably have its indentation fixed: Suggestion: } else { src/java.base/share/classes/java/lang/Thread.java line 1622: > 1620: // The VM recognizes this method as special, so any changes to the > 1621: // name or signature require corresponding changes in > 1622: // JVM_FindScopedValueBindings(). Suggestion: /** * The VM recognizes this method as special, so any changes to the * name or signature require corresponding changes in * JVM_FindScopedValueBindings(). */ @Hidden @ForceInline ------------- PR: https://git.openjdk.org/jdk/pull/10952