On Wed, 30 Nov 2022 18:48:30 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:
> This causes jar to not compress the `META-INF/` directory entry, for > consistency with the handling of other directory entries and compliance with > `APPNOTE.TXT`, and for compatibility with other zip implementations. I don't necessarily see anything wrong with the change. This code dates back to at least JDK 1.2.1. I am not sure their is an actual issue based on my read of the APP.NOTE and a quick look at the generated bytes, but I also do not see any harm with the change as to your point this is done for other directories via the jar tool as well as other zip tools such as info zip The test does not check to see if the method is stored. I would also consider converting the test to TestNG as you can leverage its assertXXX methods and remove the need for the doTest() method ------------- PR: https://git.openjdk.org/jdk/pull/11441
