On Mon, 5 Dec 2022 13:32:38 GMT, Alan Bateman <[email protected]> wrote:
>> Doug Simon has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> generalized ClassLoader::has_jvmci_module to is_module_resolvable
>
> src/hotspot/share/classfile/classLoader.cpp line 1419:
>
>> 1417:
>> 1418: // Returns true if jdk.internal.vm.ci is present on the file system.
>> 1419: bool ClassLoader::has_jvmci_module() {
>
> Would it be more useful to pass the module name so that the function tests if
> the module is is in the run-time image so that ClassLoader doesn't need to
> know the name "jdk.internal.vm.ci"?
Yes, good idea:
[3e89d40253b70251f9a2facce4b1d8d69701c045](https://github.com/openjdk/jdk/pull/11513/commits/3e89d40253b70251f9a2facce4b1d8d69701c045)
I also fixed a bug due in the size computation of `path`. Ideally, I'd factor
out and re-use the same code in `ClassLoader::add_to_exploded_build_list`.
However, the latter uses a `ResourceMark` which is not available when calling
`is_module_resolvable` early in VM startup before `JavaThread` is initialized.
-------------
PR: https://git.openjdk.org/jdk/pull/11513
