On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato <[email protected]> wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.internal.le` terminal by default, or jshell implementation if
>> available. A corresponding CSR has been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Making the wrapper classes static
src/java.base/share/classes/java/io/ProxyingConsole.java line 175:
> 173:
> 174: public WrappingWriter(PrintWriter pw, Object lock) {
> 175: super(pw);
PrintWriter doesn't provide a way to provide to lock object so this means the
overridden methods will synchronize on "lock", the non-overridden methods will
synchronize on "pw". So we will need to look at this.
-------------
PR: https://git.openjdk.org/jdk/pull/11421
