On Wed, 7 Dec 2022 19:59:08 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> Should the masking out unassigned bits that is done in this method be > extended to the existing `AccessFlag.maskToAccessFlags(mask, location)`; > Instead of throwing `IllegalArgumentException`? The two methods should be > consistent in this regard and build their return values on the meta-data in > each AccessFlag. My prior comment "The difference in exception handling behavior compared to the method w/o a ClassFileFormatVersion argument should at least be discussed." was calling attention to the differing strict vs lax handling of unexpected bits in the two overloaded methods. If the policies are not the same, there should at least be prominent text nothing and explaining the difference. ------------- PR: https://git.openjdk.org/jdk/pull/11399
