On Mon, 12 Dec 2022 10:42:22 GMT, Justin King <jck...@openjdk.org> wrote:
>> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behavior or suppress errors which are intentional. The goal is to make >> OpenJDK more well defined and thus more portable across compilers and >> architectures. > > Justin King has updated the pull request incrementally with one additional > commit since the last revision: > > Simplify logic for including __ubsan_default_options > > Signed-off-by: Justin King <jck...@google.com> Nope. Some targets end up passing C++ flags to the C compiler, causing a failure. On Tue, Dec 13, 2022, 7:13 PM Erik Joelsson ***@***.***> wrote: > I tried to use a single file, but the build logic attempts to compile as > either C or C++ based on file extensions, and has logic based on it. So if > I use .cpp and the target is all .c odd things happen. The same for the > inverse. > > What happens if you just always use a .c file for this? Won't the linker > accept that? > > — > Reply to this email directly, view it on GitHub > <https://github.com/openjdk/jdk/pull/11604#issuecomment-1348591254>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHTURUZMU2TVYAD6DH5N63WNB4QRANCNFSM6AAAAAASY75DP4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > ------------- PR: https://git.openjdk.org/jdk/pull/11604
