On Wed, 4 Jan 2023 14:37:34 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Currently, `java.io.Bits` is using explicit logic to read/write various >> primitive types to/from byte arrays. Switching to the use of `VarHandle` >> access would provide better performance and less code. >> >> Also, using a standard API for these conversions means future `VarHandle` >> improvements will benefit `Bits` too. >> >> Improvements in `Bits` will propagate to `ObjectInputStream`, >> `ObjectOutputStream` and `RandomAccessFile`. >> >> Initial benchmarks and performance discussions can be found here: >> https://github.com/openjdk/panama-foreign/pull/762 > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Use canonical NaN values to me latest change looks fine. I would simplify the test setup as Alan said, but this is out of scope of my review. I thought for testing you would use `--patch-module` and inject the test classes into the same package as Bits class? ------------- Marked as reviewed by uschindler (Author). PR: https://git.openjdk.org/jdk/pull/11840
