On Wed, 25 Jan 2023 17:49:59 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert culture attribute
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties
> line 113:
>
>> 111:
>> doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528
>> @inheritDoc
>> 112:
>> doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>> {0}
>> 113:
>> doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684
>> exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301
>> @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>
> Should `exception-type` be translated?
The translation tool didn't seem to translate this. Either because it couldn't
or because it somehow missed it. I'm not sure which, but I'm open to replacing
this with a translation suggestion you have. Or I can leave it as is.
> src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties
> line 32:
>
>> 30:
>> err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519:
>> {1}
>> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
>> 32:
>> err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199
>> Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
>
> While personally I like to see Chinese-style punctuation marks (Ex: `：`) used
> in Chinese contexts instead of their English-style ones (Ex: `:`), it's only
> updated on this single line and all the others are still using the
> English-style.
>
> There should be a general rule on which style we should use throughout all
> display messages.
Updated the punctuation (colons and comma) to be more consistent throughout the
file.
-------------
PR: https://git.openjdk.org/jdk20/pull/116
