On Mon, 9 Jan 2023 09:22:25 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Currently, `java.io.Bits` is using explicit logic to read/write various >> primitive types to/from byte arrays. Switching to the use of `VarHandle` >> access would provide better performance and less code. >> >> Also, using a standard API for these conversions means future `VarHandle` >> improvements will benefit `Bits` too. >> >> Improvements in `Bits` will propagate to `ObjectInputStream`, >> `ObjectOutputStream` and `RandomAccessFile`. >> >> Initial benchmarks and performance discussions can be found here: >> https://github.com/openjdk/panama-foreign/pull/762 > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Remove faulty test tag, improve other test tag, fix comments The code in ZoneOffset isn't applicable for multiple reasons. 1) Its a CharSequence (concretely a String), not a byte array. 2) Adjacent elements are not binary and joined by a 8bit shift; there's a multiply by 10 in the middle. ------------- PR: https://git.openjdk.org/jdk/pull/11840
