On Thu, 2 Feb 2023 15:04:57 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> This PR suggests improving performance by using the newly introduced class
>> `jdk.internal.util.ByteArray` to improve packing/unpacking operations.
>>
>> The PR also proposes adding a `ByteArrayLittleEndian` class for support for
>> little endian packing/unpacking.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix problem in benchmark
Looks good.
Thanks for the JMH benchmarks.
src/java.base/share/classes/jdk/internal/util/ByteArrayLittleEndian.java line
420:
> 418: }
> 419:
> 420: private static VarHandle create(Class<?> viewArrayClass) {
Renaming the method to `createLittleEndian` would make the static assignments
at the top unambiguous.
-------------
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12204
