On Mon, 6 Feb 2023 12:01:19 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>> Nice, I have updated the PR such that the new shared secret is replaced with >> using getBytesNoRepl instead. If there is a performance difference, it seems >> to hide in the noise. >> >> I had expected such a regression to be caught by existing tests, which seems >> not to be the case. I added TestZipFileEncodings.latin1NotAscii to adress >> this. > > getBytesNoRepl throws CharacterCodingException "for malformed input or > unmappable characters". > > This should never happen since initCEN should already reject it. If it should > happen anyway, I return NO_MATCH which will ignore the match just like the > catch in getEntryPos currently does. Yes, this should be fine. ------------- PR: https://git.openjdk.org/jdk/pull/12290
