On Tue, 7 Feb 2023 16:02:19 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct overflow limit in regression test.
>
> src/java.base/share/classes/java/lang/FdLibm.java line 1215:
>
>> 1213: * only sinh(0)=0 is exact for finite x.
>> 1214: */
>> 1215: static class Sinh {
>
> For clarity, should this not be declared `final`?
Hmm. Wouldn't hurt to do so.
I was thinking of making a pass over Fdlibm.java at some point to make sure the
nested classes had package-level rather than public accessibility and that the
classes had private constructors that threw an exception (to prevent
instantiation).
-------------
PR: https://git.openjdk.org/jdk/pull/12429
