On Tue, 7 Feb 2023 20:38:40 GMT, Matthew Donovan <[email protected]> wrote:
>> Removed SSLSocketParametersTest.sh script (which just called a Java file)
>> and configured the java code to run directly with jtreg
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> added exceptions for cases 4 and 5
Changes requested by rriggs (Reviewer).
test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 34:
> 32: * @run main/othervm SSLSocketParametersTest 5
> 33: * @run main/othervm SSLSocketParametersTest 6
> 34: * @run main/othervm SSLSocketParametersTest 7
Is a fresh VM needed for each of these tests?
>From a naive point of view it appears that 1, 2, 3, 4, 6, 7 use the same
>system properties.
The tests would complete more quickly if they could run the compatible tests in
a single VM.
Perhaps main() could iterate over the args[n] and run the corresponding test.
test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 168:
> 166: public void runTest(String[] args) {
> 167:
> 168: int test = Integer.parseInt(args[0]);
Move the parseInt to main() and call runTest with the test number.
test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 261:
> 259: }
> 260: break;
> 261: default:
The default should be retained to produce an error.
-------------
PR: https://git.openjdk.org/jdk/pull/11910
