On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd <d...@openjdk.org> wrote:
>> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work, this also impacts build reproducibility for native image generators >> which might already have a strategy to cope with hidden classes but cannot >> cope with indeterminate definition order for lambda proxy classes. >> >> This solves JDK-8292914 by making lambda proxy names always be stable >> without any configuration needed. This would also replace #10024. > > David M. Lloyd has updated the pull request incrementally with two additional > commits since the last revision: > > - Many tests have patterns for lambda class names; update them > - Update comments and javadoc showin the old pattern As a separate issue (not intended to block this one), "dump generated code for debugging" is common to a number of bootstraps, many of which use (or will use) hidden classes, and it would be good to have shared infrastructure for this. On 2/23/2023 11:45 AM, Mandy Chung wrote: > > I like John's suggestion to rename the dump file. The simple change > would be to dump the class in a temp file in the dumper directory and > then rename it if the hidden class is defined successfully. @dmlloyd > <https://github.com/dmlloyd> what do u think? > > — > Reply to this email directly, view it on GitHub > <https://github.com/openjdk/jdk/pull/12579#issuecomment-1442096713>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABJ4RAMN4FF4LKYPCHO2V3WY6HZVANCNFSM6AAAAAAU5ELQRU>. > You are receiving this because you commented.Message ID: > ***@***.***> > ------------- PR: https://git.openjdk.org/jdk/pull/12579
