On Sat, 25 Feb 2023 13:38:05 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Do some refactoring & cleanup suggested in reviews. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2765: > >> 2763: * any other methods; in this case the class is definitely >> responsible. >> 2764: */ >> 2765: BiPredicate<MethodSymbol, MethodSymbol> >> buildResponsiblePredicate(Type site, > > this method not only builds the predicate as its name indicates, it also > removes methods from the `methodGroups`, not saying that we should split this > method but I think that this removing activity should be mentioned in the > comment above Oops, my bad - previous refactoring was incomplete. Should be fixed in e25ceced163. Thanks again for the careful review! ------------- PR: https://git.openjdk.org/jdk/pull/12645
