> The solution proposed by Stefan K
> 
> The startProcess() might wait forever for the expected line if the process 
> exits (failed to start). It makes sense to just fail earlier in such cases.
> 
> The fix also move
> 'output = new OutputAnalyzer(this.process);'
> in method xrun() to be able to try to print them in waitFor is 
> failed/interrupted.

Leonid Mesnik has updated the pull request incrementally with two additional 
commits since the last revision:

 - latch != updated
 - message improved

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12751/files
  - new: https://git.openjdk.org/jdk/pull/12751/files/02770459..5ecb0047

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12751&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12751&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12751.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12751/head:pull/12751

PR: https://git.openjdk.org/jdk/pull/12751

Reply via email to