On Thu, 16 Feb 2023 13:43:32 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BytecodeHelpers.java
> line 54:
>
>> 52: */
>> 53: public class BytecodeHelpers {
>> 54: // public static Map<ConstantDesc, Opcode> constantsToOpcodes = new
>> HashMap<>(16);
>
> Should this be removed?
yes, fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/impl/BytecodeHelpers.java
> line 56:
>
>> 54: // public static Map<ConstantDesc, Opcode> constantsToOpcodes = new
>> HashMap<>(16);
>> 55:
>> 56: public BytecodeHelpers() {
>
> Should this also be removed (same as default constructor) ?
I set the constructor to private as there are no instances created.
> src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line 30:
>
>> 28: * An open-chain multimap used to map nonzero hashes to indexes (of
>> either CP
>> 29: * elements or BSM entries). Code transformed from public domain
>> implementation
>> 30: *
>> (http://java-performance.info/implementing-world-fastest-java-int-to-int-hash-map/).
>
> Could not open this link - seems to redirect to main page
Direct link does not work, I've fixed it to point to the home page.
> src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line
> 192:
>
>> 190: return (int)s;
>> 191: }
>> 192: }
>
> Watch for newlines
fixed, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
