On Wed, 1 Mar 2023 02:32:23 GMT, Xiaohong Gong <[email protected]> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Adjust whitespace as suggested in review
>> - Replace Blackhold.consume with return values
>
> test/micro/org/openjdk/bench/jdk/incubator/vector/EqualsIgnoreCaseBenchmark.java
> line 61:
>
>> 59: len = a.length;
>> 60: }
>> 61: @Benchmark
>
> Style: Insert one blank line between line 60-61?
I have inserted a new line. Thanks for your close reading!
> test/micro/org/openjdk/bench/jdk/incubator/vector/EqualsIgnoreCaseBenchmark.java
> line 124:
>
>> 122: }
>> 123:
>> 124: public boolean scalarEqualsIgnoreCase(byte[] a, byte[] b, int len)
>> {
>
> Style: remove one more space between "`public boolean`" please?
Extra space removed.
> test/micro/org/openjdk/bench/jdk/incubator/vector/EqualsIgnoreCaseBenchmark.java
> line 147:
>
>> 145: return false; // Low ASCII
>> 146: }
>> 147: return ( U <= 'Z' // In range A-Z
>
> Style: remove one more space between `( U` please?
Thanks, removed the extra space.
-------------
PR: https://git.openjdk.org/jdk/pull/12790
